[Webkit-unassigned] [Bug 45423] [Gtk] Port tiled backing store

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45423





--- Comment #15 from Julien Chaffraix <jchaffraix at webkit.org>  2010-10-06 19:36:37 PST ---
> Looks good. I think we should avoid adding the option to GtkLauncher, as we try to keep it very minimal and it isn't strictly necessary there. Since this is an API change, it will need the approval of another GTK+ reviewer as well.

I don't mind avoiding another option is that is what the GTK reviewers prefer.

> Do you mind using the same license formatting as other files in the WebCore/graphics/gtk/ directory? There's an example of a BSD license in FontGtk.cpp. We should be as consistent as possible.

This will be an issue. There is a couple of non-trivial differences in wording with respect to the other licenses which means that I will need to run it through our legal department (which usually take a least 3 weeks to reply :-/).

> Can you confirm that this is needed here or if doing it in ::contentsSizeChanged is enough. I just took a guess on where this was necessary, so I'm just surprised that I was right. :)

I will double check and update the patch accordingly.

The other comments will be taken care in the next version. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.