[Webkit-unassigned] [Bug 47240] new-run-webkit-tests: getting an "error 2" back from ImageDiff

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47240





--- Comment #4 from Dirk Pranke <dpranke at chromium.org>  2010-10-06 15:29:10 PST ---
hm. i thought someone (shans@?) saw this on windows as well ...

regardless of whether not there's something wrong with this PNG, it's clear that we hadn't really considered what would happen if image_diff/ImageDiff returns an error. 

I'm not sure what the right thing to do is, but I would propose that it's something along the lines of (a) log a useful error message at the ERROR level so that it actually shows up all the time, and  (b) mark the test as failed, but continue on.

By "useful error message", I mean something like we have in the above log, but actually return the full command that failed (like we do in the execute debug statement, but at the ERROR level).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.