[Webkit-unassigned] [Bug 47173] Web Inspector: extract Inspector Instrumentation API as a class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47173


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69953|review?                     |review-
               Flag|                            |




--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2010-10-06 14:02:12 PST ---
(From update of attachment 69953)
View in context: https://bugs.webkit.org/attachment.cgi?id=69953&action=review

> WebCore/ChangeLog:27
> +        (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):

You should nuke these scary verbose lines.

> WebCore/bindings/v8/V8Proxy.cpp:414
> +    InspectorInstrumentation::didEvaluateScript(m_frame, cookie);

I think cookie should be the first parameter in all the calls.

> WebCore/inspector/InspectorInstrumentation.cpp:-67
> -    if (!inspectorController->hasFrontend())

Why did these go? Please explain in order to get r+.

> WebCore/inspector/InspectorInstrumentation.h:116
> +    static InspectorInstrumentationCookie willCallFunctionImpl(InspectorController*, const String& scriptName, int scriptLine);

This is crazy amount of methods, really easy to make a mistake here. Can we cut the number?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.