[Webkit-unassigned] [Bug 47244] [GTK] editing/pasteboard/dataTransfer-setData-getData.html fails on GTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47244





--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2010-10-06 12:17:25 PST ---
(In reply to comment #5)

Thanks for the comments.

> > WebCore/platform/gtk/DataObjectGtk.cpp:66
> > +    // This code is originally from: platform/chromium/ChromiumDataObject.cpp.
> Can you add a FIXME that says we should try to refactor this code for sharing across platforms?

Done.
> > WebCore/platform/gtk/DataObjectGtk.cpp:104
> >  void DataObjectGtk::setURL(const KURL& url, const String& label)
> >  {
> > +    m_url = url;
> This seems redundant since setURIList should do this for you.

Instead of using setURIList here, I've switched it to simply do m_uriList = url;, to avoid any unintended side-effects (like settings files on the DataObject).

> > WebCore/platform/gtk/PasteboardHelper.cpp:141
> > +        CString uriList = dataObject->uriList().utf8();
> > +        gtk_selection_data_set(selectionData, uriListAtom, 8,
> > +            reinterpret_cast<const guchar*>(uriList.data()), strlen(uriList.data()) + 1);
> Would urList.length() + 1 be better than calling strlen?

It definitely is! Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.