[Webkit-unassigned] [Bug 47278] Add WebThemeEngine api for chromium/linux

Wed Oct 6 11:26:55 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=47278

Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69967|review?                     |review-
               Flag|                            |

--- Comment #7 from Tony Chang <tony at chromium.org>  2010-10-06 11:26:55 PST ---
(From update of attachment 69967)
View in context: https://bugs.webkit.org/attachment.cgi?id=69967&action=review

> I can't remove the old WebThemeEngine.h without breaking the chromium build. I'll do it once I've added support for the new api there, and changed its includes.

Right, I just mean to remove it from the gyp file (I think that's harmless, it just changes what file the IDE tries to open).  You can still change the include in WebKit/chromium/src/ChromiumBridge.cpp, right?

r- for ChangeLog

> ChangeLog:1
> +2010-10-06  Dave Moore  <davemoore at chromium.org>

Actually, this is the wrong ChangeLog file.  You want to edit WebKit/ChangeLog not the root ChangeLog.  I think if you're going to use webkit-patch, you need to have a full WebKit checkout.  Alternately, you can probably use the svn based scripts from your WebKit/WebKit/ directory (i.e., manually run prepare-ChangeLog and svn-create-diff).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.