[Webkit-unassigned] [Bug 46475] [Cairo] Activate ContextShadow in all places where shadows are drawn

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46475





--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2010-10-06 10:38:13 PST ---
(In reply to comment #6)

Thanks for the comments!

> LayoutTests/platform/gtk/fast/text/shadow-no-blur looks a bit strange. Is this really a progression?

Yeah, that one is really odd. :) I think when I rebase this patch the text will show up properly there (since I've made some font fixes on GTK+). It's hard to tell right now, but previously the text shadow was clipped incorrectly and this patch fixes it.

> > WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:160
> > +enum PathDrawingStyle { Fill, Stroke };
> > +static inline void drawPathShadow(GraphicsContext* context, GraphicsContextPrivate* gcp, PathDrawingStyle drawingStyle)
> 
> I would add a newline. Doesn't an enum for fill and stroke exists some how?

I'll see if I can find something.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.