[Webkit-unassigned] [Bug 47232] webkit-patch rebaseline should cover more cases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47232





--- Comment #10 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2010-10-06 10:24:52 PST ---
(In reply to comment #9)
> > Yup, it's not a perfect solution, but still better than the current behavior, where I have to _know_ to move the files manually after rebaselining is done.
> 
> 99%, putting them in the chromium-win directory should work fine, no? I guess, I still don't follow what exactly you're proposing. We run an XP bot, so are you saying we should always put the results in chromium-win-xp?

Let me illustrate. I did this with the tool: http://trac.webkit.org/changeset/68990. Then I had to tweak it by hand here: http://trac.webkit.org/changeset/68991

The problem here is that putting things into chromium-win is a no-op when there's a platform-specific baseline. Thus, rebaselining as it works currently doesn't produce results you expect it to produce (in the example above, one test was still failing). Based on my experience with gardeners, this is a well-known and poorly understood source of confusion. 

BTW, we run both vista and xp at the moment (Vista on build.webkit.org, XP downstream).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.