[Webkit-unassigned] [Bug 46738] Web Inspector: add event listener breakpoints sidebar pane

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46738





--- Comment #13 from Pavel Podivilov <podivilov at chromium.org>  2010-10-06 09:50:48 PST ---
(In reply to comment #11)
> (From update of attachment 69778 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69778&action=review
> 
> > WebCore/inspector/front-end/BreakpointManager.js:150
> > +        breakpoint.compareTo = function(other)
> 
> We should introduce a dedicated class for XHR breakpoints and define the method on it.

Let me fix it in a separate patch.

> 
> > WebCore/inspector/front-end/BreakpointManager.js:292
> > +            if (breakpointId)
> 
> it'd be harmless to do the assignment even if breakpointId is undefined.

breakpointId is 0 if breakpoint was not set on backend.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.