[Webkit-unassigned] [Bug 46918] ContextShadow should not use the blur radius as kernel size of the box blurs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46918





--- Comment #16 from Alejandro G. Castro <alex at igalia.com>  2010-10-06 08:09:05 PST ---
(In reply to comment #15)
> (In reply to comment #14)
> > (From update of attachment 69617 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=69617&action=review
> > d is unsigned, you can't use unsigned d = max(2.f
> > use
> > unsigned d = max<unsigned>(2, floorf(2 / 3.f * m_blurDistance)); instead.
> > 
> you still need a static_cast<unsigned> for floorf, sorry.

Thanks for the review, I'm going to use int the distance is limited to 128 so it is not a problem, something like:

+    int d = max(2, static_cast<int>(floorf((2 / 3.f) * m_blurDistance)));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.