[Webkit-unassigned] [Bug 47232] webkit-patch rebaseline should cover more cases

Wed Oct 6 07:43:26 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=47232

--- Comment #5 from Ojan Vafai <ojan at chromium.org>  2010-10-06 07:43:26 PST ---
> > 3. Make sure svn-eol-style is set to LF and that there aren't CRLFs from grabbing the results off the windows bot
> 
> This requires an SVN working copy, right?  We run all the bots out of git working copies because SVN working copies accumulate junk over time (and are slow).

That's sucktastic. We can at least convert CRLFs to LFs.

> Also: detect when existing platform results are split to sub-platform folders (i.e. chromium-win-xp and chromium-win-vista) and do the right thing.

I don't see what the correct behavior here is. Given that we don't have bots for both of these, don't we always just want to put the results in the chromium-win directory? Alternately, XP falls back to Vista, so we could always put them in the chromium-win-vista directory.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.