[Webkit-unassigned] [Bug 46918] ContextShadow should not use the blur radius as kernel size of the box blurs
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 6 05:03:48 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=46918
Dirk Schulze <krit at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #69617|review? |review-
Flag| |
--- Comment #14 from Dirk Schulze <krit at webkit.org> 2010-10-06 05:03:48 PST ---
(From update of attachment 69617)
View in context: https://bugs.webkit.org/attachment.cgi?id=69617&action=review
Please fix the issues and I'm fine with it. r- because of the issues.
> WebCore/platform/graphics/ContextShadow.cpp:88
> + unsigned d = max(2.f, (2 / 3.f) * m_blurDistance);
d is unsigned, you can't use unsigned d = max(2.f
use
unsigned d = max<unsigned>(2, floorf(2 / 3.f * m_blurDistance)); instead.
> WebCore/platform/graphics/ContextShadow.cpp:158
> + m_layerRect.inflate((m_type == BlurShadow) ? m_blurDistance : 0);
remove the braces arround m_type == BlurShadow
> WebCore/platform/graphics/ContextShadow.cpp:171
> + m_layerRect.inflate((m_type == BlurShadow) ? m_blurDistance : 0);
Ditto.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list