[Webkit-unassigned] [Bug 47087] Use pixbufs instead of pixmaps when creating platform cursors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47087


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69922|review?                     |review-
               Flag|                            |




--- Comment #7 from Xan Lopez <xan.lopez at gmail.com>  2010-10-06 04:59:01 PST ---
(From update of attachment 69922)
View in context: https://bugs.webkit.org/attachment.cgi?id=69922&action=review

> WebCore/ChangeLog:6
> +

Usually the 'syntax' for this is, title in one line, URL in the next line. We also usually use [GTK] in the title when the bug is GTK specific.

> WebCore/ChangeLog:13
> +

So... like this, but it goes at the beginning.

> WebCore/ChangeLog:15
> +

If you don't add tests you have to remove this.

> WebCore/platform/gtk/CursorGtk.cpp:51
> +    cairo_surface_t* surface = cairo_image_surface_create(CAIRO_FORMAT_A1, 32, 32);

Should use PlatformRefPtrCairo here, see WebCore/platform/graphics/cairo/PlatformRefPtrCairo.{cpp,h}

> WebCore/platform/gtk/CursorGtk.cpp:52
> +    cairo_t* cr = cairo_create(surface);

Same thing.

> WebCore/platform/gtk/CursorGtk.cpp:60
> +    GdkPixbuf* pixbuf = gdk_pixbuf_get_from_surface(surface, 0, 0, 32, 32);

Use a GRefPtr here.

> WebCore/platform/gtk/GtkVersioning.h:97
> +

Group this with the already existing #ifdef GTK_API_VERSION_2 thing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.