[Webkit-unassigned] [Bug 47181] SVGFEMergeNodeElement doesn't support dynamic invalidation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47181


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69921|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #6 from Nikolas Zimmermann <zimmermann at kde.org>  2010-10-06 04:50:53 PST ---
(From update of attachment 69921)
View in context: https://bugs.webkit.org/attachment.cgi?id=69921&action=review

Other than that it looks good...

> WebCore/svg/SVGFEMergeNodeElement.cpp:62
> +    if (attrName != SVGNames::inAttr)
> +        return;
> +    if (Node* parentNode = parent()) {
> +        RenderObject* renderer = parentNode->renderer();
> +        if (renderer && renderer->isSVGResourceFilterPrimitive())
> +            RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);
> +    }
> +}

Sorry, for not being clear. I meant:

if (attrName != SVGNames::inAttr)
    return;

Node* parentNode = parent();
if (!parentNode)
    return;

RenderObject* renderer = parentNode->renderer();
if (!renderer || !renderer->isSVGResourceFilterPrimitive())
    return;

RenderSVGResource::mark...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.