[Webkit-unassigned] [Bug 47181] SVGFEMergeNodeElement doesn't support dynamic invalidation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47181


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69913|review?                     |review-
               Flag|                            |




--- Comment #4 from Nikolas Zimmermann <zimmermann at kde.org>  2010-10-06 04:04:01 PST ---
(From update of attachment 69913)
View in context: https://bugs.webkit.org/attachment.cgi?id=69913&action=review

Looks good other than that, though as you can't commit yet on your own, you probably need to upload a new patch, hence r-.

> WebCore/ChangeLog:8
> +        Since feMergeNode doesn't have own renderer, we have to call the invalidation via it's parent.

s/it's/its/

> WebCore/svg/SVGFEMergeNodeElement.cpp:55
> +    if (attrName == SVGNames::inAttr) {

If there's only one attribute to consider, you may want to use early exit style here.
if (attrName != SVGNames::inAttr)
    return;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.