[Webkit-unassigned] [Bug 47173] Web Inspector: extract Inspector Instrumentation API as a class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47173





--- Comment #5 from Ilya Tikhonovsky <loislo at chromium.org>  2010-10-06 03:30:31 PST ---
(From update of attachment 69777)
View in context: https://bugs.webkit.org/attachment.cgi?id=69777&action=review

> WebCore/dom/Node.cpp:2605
> +    int instrumentationCookie = InspectorInstrumentation::willDispatchEvent(document(), *event, targetForWindowEvents, this, ancestors);

Nit: InspectorInstrumentationCookie cookie?

> WebCore/inspector/InspectorInstrumentation.cpp:313
> +    if (InspectorTimelineAgent* timelineAgent = inspectorController->m_timelineAgent.get()) {

Nit: I think it'd be better to have overloaded function for retrieving timelineAgent. like retrieveTimelineAgent(InspectorController*)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.