[Webkit-unassigned] [Bug 47044] Add FileSystemSync implementation for Worker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47044


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69901|review?                     |review+
               Flag|                            |




--- Comment #8 from David Levin <levin at chromium.org>  2010-10-06 01:59:18 PST ---
(From update of attachment 69901)
View in context: https://bugs.webkit.org/attachment.cgi?id=69899&action=review

Just a few nits to address.

> WebCore/fileapi/DOMFileSystemBase.h:72
> +    bool getFile(const EntryBase* base, const String& path, PassRefPtr<Flags>, PassRefPtr<EntryCallback>, PassRefPtr<ErrorCallback>);

remove "base"

> WebCore/fileapi/DOMFileSystemBase.h:73
> +    bool getDirectory(const EntryBase* base, const String& path, PassRefPtr<Flags>, PassRefPtr<EntryCallback>, PassRefPtr<ErrorCallback>);

remove "base"

> WebCore/fileapi/FileEntry.h:-42
> -class DOMFileSystem;

Please consider adding this back but as Base.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.