[Webkit-unassigned] [Bug 47087] Use pixbufs instead of pixmaps when creating platform cursors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47087


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-10-06 01:19:41 PST ---
Attachment 69897 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Last 3072 characters of output:
ent?  [whitespace/indent] [3]
WebCore/platform/gtk/GtkVersioning.c:249:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/GtkVersioning.c:254:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/GtkVersioning.c:254:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/GtkVersioning.c:255:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/GtkVersioning.c:255:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/GtkVersioning.c:256:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/GtkVersioning.c:256:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/gtk/GtkVersioning.c:257:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebCore/platform/gtk/GtkVersioning.c:258:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/GtkVersioning.c:262:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/GtkVersioning.c:263:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/GtkVersioning.c:264:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/GtkVersioning.c:265:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/GtkVersioning.c:266:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/GtkVersioning.c:269:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/GtkVersioning.c:270:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/GtkVersioning.c:271:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/GtkVersioning.c:272:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/GtkVersioning.c:273:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/GtkVersioning.c:277:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/GtkVersioning.c:277:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/GtkVersioning.c:278:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/GtkVersioning.c:280:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/gtk/GtkVersioning.h:95:  Tab found; better to use spaces  [whitespace/tab] [1]
WebCore/platform/gtk/GtkVersioning.h:95:  dest_x is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 107 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.