[Webkit-unassigned] [Bug 46775] getBoundingClientRect does not work with SVG <text>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46775





--- Comment #5 from Nikolas Zimmermann <zimmermann at kde.org>  2010-10-06 00:00:52 PST ---
(In reply to comment #3)
> Created an attachment (id=69813)
 --> (https://bugs.webkit.org/attachment.cgi?id=69813) [details]
> Fix, layout test and code cleanup
> 
> I am submitting the straightforward solution, checking for isText in addition to isStyledLocatable.
Will check your patch soon.

> 
> If you want me to make SVGTextElement a subclass of SVGStyledLocatable, please let me know, and I will try implementing this new design this in a separate patch.
No, that would be wrong, SVGTextContent doesn't implement the SVGLocatable interface, but SVGTransformable. Though we can't use SVGStyledTransformable as base class for SVGTextElement, because SVGTextContentElement already inherits from SVGStyledElement. To make it clear:

SVGTextElement : SVGTextPositioningElement, SVGTransformable
SVGTextPositioningElement : SVGTextContentElement
SVGTextContentElement : SVGStyledElement, SVGTests, SVGLangSpace, SVGExternalResourcesRequired

This class hiearchy 1:1 maps the SVG specification.

> 
> Also, if you want me to fix SVGLocatable::getTransformToElement by accounting for SVGTextElement in addition to SVGStyledLocatableElement when calling getCTM, please tell me, and I'll open a separate bug where I will fix it.

Will check your patch first :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.