[Webkit-unassigned] [Bug 45982] Web Inspector: FileSystem integration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45982





--- Comment #7 from Kinuko Yasuda <kinuko at chromium.org>  2010-10-05 23:59:07 PST ---
(In reply to comment #6)
> (From update of attachment 69873 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69873&action=review
> >> WebCore/platform/AsyncFileSystem.h:122
> >> +    virtual String root() const { return m_platformRootPath; }
> > 
> > virtual const String& root() const { return m_platformRootPath; }
> > 
> > does this need to be virtual?
> 
> @Kinuko Yasuda: I am usually opposed to returning const references to internals (see abarth's recent message). Is there a big performance win in the case?

I usually return a const reference if it's reasonable (I'm positive this code is safe) but on the second thought with WebCore's String it won't change anything... if you don't like to do that please never mind.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.