[Webkit-unassigned] [Bug 44935] [Qt] Web process crash when pressing modifiers in input field

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 5 22:55:30 PDT 2010


--- Comment #18 from Kimmo Kinnunen <kimmo.t.kinnunen at nokia.com>  2010-10-05 22:55:29 PST ---
(In reply to comment #13)
> (From update of attachment 69773 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69773&action=review
> > WebCore/platform/qt/PlatformKeyboardEventQt.cpp:579
> > +}
> We should reorganize the members in the enum to do this test it in O(1). Do you agree?

We should, especially if it shows up in your profiles as a hotspot. Did it? It really doesn't show up for me, though, so it seems a bit of a wasted effort, effort which I would like to spend in some other place.

I don't know the optimization technique. I cannot modify the enum as it is implemented in Qt.  Do you mean that the order of the case statements should match the order of the enum values? 

I'll attach an example output from my compiler. I'm no expert in this, so I cannot say for sure, but something seems to be rearranged by the looks of it.

If the output doesn't match your expectation, feel free to rearrange switch.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list