[Webkit-unassigned] [Bug 45443] [GTK] Support for viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45443





--- Comment #21 from Joone Hur <joone at kldp.org>  2010-10-05 22:25:05 PST ---
(In reply to comment #17)
> (From update of attachment 69762 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69762&action=review
>
> > WebKit/gtk/webkit/webkitviewportconfig.h:58
> > +WEBKIT_API WebKitViewportConfig*
> > +webkit_viewport_config_new                      (gint desktopWidth,
> > +                                                 gint deviceWidth,
> > +                                                 gint deviceHeight,
> > +                                                 gint deviceDPI);
>
> I see no reason for the API user to create a new WebKitViewportConfig object, I would remove this. Also, perhaps naming this WebKitViewportFeatures, since we have WindowFeatures would make it easier to understand what this is about?

Yes, right.  I will remove this function from the public header file and change WebKitViewportConfig to WebKitViewportFeatures.


> > WebKit/gtk/webkit/webkitwebview.cpp:4497
> > +void webkit_web_view_set_viewport_config(WebKitWebView* webView, WebKitViewportConfig* viewportConfig)
> > +{
> > +    g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
> > +    g_return_if_fail(WEBKIT_IS_VIEWPORT_CONFIG(viewportConfig));
> > +
> > +    webView->priv->viewportConfig = viewportConfig;
>
> It looks like we don't communicate the change to WebCore - I believe there is no real point to, anyway, right? Unless you change the viewport stuff through the DOM itself. I wouldn't allow setting the viewport features into the view.

As Kenneth said, when the size of the viewport is changed, we need to compute the optimal viewport configuration again. Therefore, there should be a way of accessing the viewportConfig via the view like getting the WindowFeatures.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.