[Webkit-unassigned] [Bug 47234] [BREWMP] Translate key code in PlatformKeyboardEvent with IKeysMapping

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47234


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69871|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #3 from Kent Tamura <tkent at chromium.org>  2010-10-05 18:35:55 PST ---
(From update of attachment 69871)
View in context: https://bugs.webkit.org/attachment.cgi?id=69871&action=review

> WebCore/platform/brew/PlatformKeyboardEventBrew.cpp:160
> +    if ((m_type == Char) && modifiers) {

nit: Checking "m_type" and checking "type" are mixed in the constructor.  It's confusing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.