[Webkit-unassigned] [Bug 46493] [chromium] Add mipmap support for ImageLayerChromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46493


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69637|review?                     |review+
               Flag|                            |




--- Comment #23 from James Robinson <jamesr at chromium.org>  2010-10-05 13:14:29 PST ---
(From update of attachment 69637)
View in context: https://bugs.webkit.org/attachment.cgi?id=69637&action=review

Looks good

> WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:272
> +    bool generateMipmap = (requestMipmap == useMipmap)
> +                          && (layerRenderer()->contentLayerSharedValues()->npotSupported()
> +                          || (isPowerOfTwo(updateRect.width()) && isPowerOfTwo(updateRect.height())));

nit: the indentation is a little odd here.  Maybe indent the || line a bit more so it's clearer?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.