[Webkit-unassigned] [Bug 47070] [Texmap] [Qt] Texture mapper initial implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 5 11:15:23 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=47070
--- Comment #13 from Kenneth Rohde Christiansen <kenneth at webkit.org> 2010-10-05 11:15:23 PST ---
(From update of attachment 69811)
View in context: https://bugs.webkit.org/attachment.cgi?id=69811&action=review
> WebCore/WebCore.pro:214
> +QT += opengl
So even if we are not using this we force opengl?
> WebCore/platform/graphics/opengl/TextureMapperGL.cpp:81
> + if (err)
> + WTFReportError(__FILE__, line, WTF_PRETTY_FUNCTION, "[TextureMapper GL] Command failed: %s (%x)\n", command, err);
we normally do
if (!err)
return;
> WebCore/platform/graphics/opengl/TextureMapperGL.cpp:172
> +// LOG(infoLog);
We dont want to commit this
> WebCore/platform/graphics/opengl/TextureMapperGL.cpp:184
> +TextureMapperGL::TextureMapperGL(GraphicsContext* context)
can't some of these different classes be in different files?
> WebCore/platform/graphics/opengl/TextureMapperGL.cpp:479
> +}
> +bool BitmapTextureGL::isValid() const
missing newline here
> WebCore/platform/graphics/opengl/TextureMapperGL.cpp:501
> +
> +
excessive newline here
> WebCore/platform/graphics/opengl/TextureMapperGL.cpp:538
> + const BitmapTextureGL& surface = static_cast<const BitmapTextureGL&>(aSurface);
> + // Create the model-view-projection matrix to display on screen.
I would add a new line before the comment
> WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:698
> +// if (m_pendingContent.contentType == HTMLContentType)
> +// recache(m_pendingContent.regionToUpdate);
dont add outcommented code
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list