[Webkit-unassigned] [Bug 46405] Add idl and mock classes for FileSystemSync for FileSystem API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46405





--- Comment #15 from Kinuko Yasuda <kinuko at chromium.org>  2010-10-05 05:27:24 PST ---
(In reply to comment #12)
> (From update of attachment 69567 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69567&action=review
> 
> Drive by comments
> 
> > WebCore/bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:72
> > +       EXCEPTION_BLOCK(Flags*, tmp_flags, V8Flags::HasInstance(args[1]) ? V8Flags::toNative(v8::Handle<v8::Object>::Cast(args[1])) : 0);
> 
> I don't think you need to wrap this code into EXCEPTION_BLOCK as there is nothing that can throw an exception (unless I miss something)

Thanks for the comment, fixed.

> >> WebCore/bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:109
> >> +    }
> > 
> > Duplicate code. consider a common function.
> 
> As another thought: why you need that to be custom?  Maybe you should just extend code generator?

Right that would be ideal.  I have a proposing patch for this, which somehow works (but slow)... it'd be great if you could take a look at it as well.
https://bugs.webkit.org/show_bug.cgi?id=45237

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.