[Webkit-unassigned] [Bug 47011] Add AudioUtilities files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47011


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69682|review?                     |review+
               Flag|                            |




--- Comment #5 from Kenneth Russell <kbr at google.com>  2010-10-04 15:10:35 PST ---
(From update of attachment 69682)
View in context: https://bugs.webkit.org/attachment.cgi?id=69682&action=review

Looks fine overall. One small comment; up to you whether to make this change IMO.

> WebCore/platform/audio/AudioUtilities.cpp:37
> +    return pow(10.0, 0.05 * decibels);

Strictly, this .0 and the others throughout this file are not necessary according to WebKit style ("Floating point literals" on http://webkit.org/coding/coding-style.html ).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.