[Webkit-unassigned] [Bug 46528] Add BiquadDSPKernel files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46528


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68770|review?                     |review-
               Flag|                            |




--- Comment #2 from Kenneth Russell <kbr at google.com>  2010-10-04 15:07:38 PST ---
(From update of attachment 68770)
View in context: https://bugs.webkit.org/attachment.cgi?id=68770&action=review

Code generally looks good; one change, plus please update the copyright notice.

> WebCore/webaudio/BiquadDSPKernel.h:56
> +    BiquadProcessor* m_biquadProcessor;

Please remove this weak pointer and instead provide a helper method which downcasts the superclass's pointer. Having multiple pointers in multiple classes all pointing to the same storage makes understanding the lifetime difficult. Also, the superclass doesn't maintain an OwnPtr; who actually owns the AudioDSPKernelProcessor* in the superclass?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.