[Webkit-unassigned] [Bug 46495] Add AudioBasicProcessorNode files

Mon Oct 4 14:55:46 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46495

Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69520|review?                     |review-
               Flag|                            |

--- Comment #3 from Kenneth Russell <kbr at google.com>  2010-10-04 14:55:46 PST ---
(From update of attachment 69520)
View in context: https://bugs.webkit.org/attachment.cgi?id=69520&action=review

This basically looks good; couple of tiny changes. r- for the license text update discussed offline.

> WebCore/webaudio/AudioBasicProcessorNode.cpp:44
> +    , m_processor(0)

m_processor does not require explicit initialization.

> WebCore/webaudio/AudioBasicProcessorNode.cpp:85
> +            // FIXME: if we take "tailTime" into account, then we can avoid calling processor()->process() once the tail dies down.

Is tailTime concretely defined somewhere? If so, please mention where in the comment; otherwise, change to "tail time".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.