[Webkit-unassigned] [Bug 46532] Add LowPass2FilterNode files

Mon Oct 4 14:28:24 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46532

Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68774|review?                     |review-
               Flag|                            |

--- Comment #2 from Kenneth Russell <kbr at google.com>  2010-10-04 14:28:23 PST ---
(From update of attachment 68774)
View in context: https://bugs.webkit.org/attachment.cgi?id=68774&action=review

The code looks OK, but I'm marking this r- for the license update as discussed offline. Please also consider getting the Web Audio spec up to date with this change before landing it.

> WebCore/webaudio/LowPass2FilterNode.idl:34
> +    ] LowPass2FilterNode : AudioNode {

http://chromium.googlecode.com/svn/trunk/samples/audio/specification/specification.html#APIOverview-section says that LowPass2FilterNode "would be" a subclass of AudioNode; I think you should modify the spec to include the API definition for this class before committing it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.