[Webkit-unassigned] [Bug 47072] Implement http locking in NRWT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 4 14:27:09 PDT 2010


--- Comment #5 from Dirk Pranke <dpranke at chromium.org>  2010-10-04 14:27:08 PST ---
(In reply to comment #1)
> Created an attachment (id=69607)
 --> (https://bugs.webkit.org/attachment.cgi?id=69607) [details]
> proposed patch

the HttpLock code looks generally pretty good, but doesn't actually have anything to do with HTTP; it's a generic file locking mechanism.  Can we rename the file? 

More importantly, the code is conceptually a platform-specific (or port-specific) abstraction. It would be nice to move this file into the port/ directory and hang it off of the port object (like we do for the http_server code). That way ports don't need to implement this if it isn't necessary, or can implement something else as appropriate.

Lastly, to address Tony's suggestion about tempfile directory locations, I'd suggest taking the directory as an argument in the constructor, and that way the port files can pass in the directory they'd like to use.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list