[Webkit-unassigned] [Bug 47097] Generate messages sent to the WebProcess class.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47097


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69660|review?                     |review+
               Flag|                            |




--- Comment #7 from Adam Roben (aroben) <aroben at apple.com>  2010-10-04 13:02:46 PST ---
(From update of attachment 69660)
View in context: https://bugs.webkit.org/attachment.cgi?id=69660&action=review

> WebKit2/ChangeLog:13
> +        * Scripts/webkit2/messages.py:
> +        * Scripts/webkit2/messages_unittest.py:
> +        Make this script work for passing a templated type. 

It would be nice to add the names of functions you changed in messages.py.

> WebKit2/WebProcess/WebProcess.cpp:194
> -void WebProcess::setCacheModel(CacheModel cacheModel)
> +void WebProcess::setCacheModel(uint32_t cacheModel)
>  {
> -    if (!m_hasSetCacheModel || cacheModel != m_cacheModel) {
> +    if (!m_hasSetCacheModel || static_cast<CacheModel>(cacheModel) != m_cacheModel) {
>          m_hasSetCacheModel = true;
> -        m_cacheModel = cacheModel;
> -        platformSetCacheModel(cacheModel);
> +        m_cacheModel = static_cast<CacheModel>(cacheModel);
> +        platformSetCacheModel(static_cast<CacheModel>(cacheModel));
>      }
>  }

I still think a local variable with type CacheModel would be better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.