[Webkit-unassigned] [Bug 47090] Don't use GtkObject

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 4 12:35:59 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=47090


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69638|                            |review-
               Flag|                            |




--- Comment #1 from Martin Robinson <mrobinson at webkit.org>  2010-10-04 12:35:59 PST ---
(From update of attachment 69638)
View in context: https://bugs.webkit.org/attachment.cgi?id=69638&action=review

This change needs a ChangeLog. :) Check the WebKit contributing page for some handy shortcuts wrt to ChangeLogs: http://webkit.org/coding/contributing.html#changelogs

> WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp:550
> +#if GTK_CHECK_VERSION (2, 90, 8)
> +    GtkAdjustment* adjustment = gtk_adjustment_new(0.0, 0.0, 100.0, 0.1, 1.0, 1.0);
> +#else
> +    GtkAdjustment* adjustment = GTK_ADJUSTMENT(gtk_adjustment_new(0.0, 0.0, 100.0, 0.1, 1.0, 1.0));
> +#endif
> +    m_timeHScale = gtk_hscale_new(adjustment);
>      gtk_scale_set_draw_value(GTK_SCALE(m_timeHScale), FALSE);

I think in this case, the extra cast is worth getting preventing #ifdefs here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list