[Webkit-unassigned] [Bug 44862] Hard to find a caret in an editable element with black background color

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44862


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ossy at webkit.org,
                   |                            |tonikitoo at webkit.org




--- Comment #24 from Ryosuke Niwa <rniwa at webkit.org>  2010-10-04 12:28:51 PST ---
(In reply to comment #21)
> 1) Do we need to display a caret at platform level rather than in WebCore?
>     Yes, because each platform has it own way of creating a caret.

Agreed.

> 2) How to display a caret for each platform
>     - Windows => XOR with the painted screen like IE 
>     - Mac => Black or White  (but, Pages always uses gray color)
>     - Linux => Black or White (but, OpenOffice uses XOR with the painted screen)

This sounds very reasonable to me.  Although TextEdit always uses black caret (insert a table and change the cell background to test this), I don't think it's user-friendly enough for us to copy this behavior on Mac.  OpenOffice is probably just mimicking the behavior of Microsoft Office, and your proposal sounds reasonable to me.

+tonikitoo, +ossy for gtk / qt.

> 3) How to change the caret color on the dark/bright background in Mac/Linux.
>     - Use the lightness value of HSL color space?

Yes, that sounds reasonable to me.  But you should use Color::getHSL instead in your patch instead of manually converting RGB values to HSL.  You can add lightless function that ignores hue and saturation if you're so inclined.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.