[Webkit-unassigned] [Bug 47097] Generate messages sent to the WebProcess class.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47097


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69651|review?                     |review-
               Flag|                            |




--- Comment #3 from Adam Roben (aroben) <aroben at apple.com>  2010-10-04 11:42:11 PST ---
(From update of attachment 69651)
View in context: https://bugs.webkit.org/attachment.cgi?id=69651&action=review

> WebKit2/WebKit2.pro:180
>  HEADERS += \
>      Shared/CoreIPCSupport/DrawingAreaMessageKinds.h \
>      Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h \
>      Shared/CoreIPCSupport/WebPageProxyMessageKinds.h \
> -    Shared/CoreIPCSupport/WebProcessMessageKinds.h \
>      Shared/CacheModel.h \
>      Shared/DrawingAreaBase.h \
>      Shared/ImmutableArray.h \

Seems like you need to add the new generated files.

> WebKit2/Platform/CoreIPC/HandleMessage.h:48
> +    // NOTE: Return value ignored.
> +    (object->*function)(firstArgument, secondArgument);
> +}

Why throw away the return value? Why not return it?

> WebKit2/Scripts/webkit2/messages.py:232
> +        if type.find("<") != -1:
> +            headers.update(headers_for_type(type))
> +            continue

Please use single quotes.

Please add tests that show that your new code works. (And make sure you didn't break any existing tests.)

> WebKit2/UIProcess/mac/WebProcessProxyMac.mm:42
> +        send(Messages::WebProcess::SetupAcceleratedCompositingPort(CoreIPC::MachPort(renderServerPort, MACH_MSG_TYPE_COPY_SEND)), 0);

Should be "SetUpAcceleratedCompositingPort", with a capital "U".

> WebKit2/WebProcess/WebProcess.cpp:194
> -void WebProcess::setCacheModel(CacheModel cacheModel)
> +void WebProcess::setCacheModel(uint32_t cacheModel)
>  {
> -    if (!m_hasSetCacheModel || cacheModel != m_cacheModel) {
> +    if (!m_hasSetCacheModel || static_cast<CacheModel>(cacheModel) != m_cacheModel) {
>          m_hasSetCacheModel = true;
> -        m_cacheModel = cacheModel;
> -        platformSetCacheModel(cacheModel);
> +        m_cacheModel = static_cast<CacheModel>(cacheModel);
> +        platformSetCacheModel(static_cast<CacheModel>(cacheModel));
>      }
>  }

Doing the cast once and storing the result in a local variable would be nicer.

> WebKit2/win/WebKit2.vcproj:766
>  					>
>  				</File>
>  				<File
> -					RelativePath="..\Shared\CoreIPCSupport\WebProcessMessageKinds.h"
> -					>
> -				</File>
> -				<File
>  					RelativePath="..\Shared\CoreIPCSupport\WebProcessProxyMessageKinds.h"
>  					>
>  				</File>
>  

Seems like you need to add the new generated files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.