[Webkit-unassigned] [Bug 46738] Web Inspector: add event listener breakpoints sidebar pane

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46738





--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org>  2010-10-04 09:58:42 PST ---
(From update of attachment 69643)
Took a quick look. View in context: https://bugs.webkit.org/attachment.cgi?id=69643&action=review

> WebCore/inspector/front-end/BreakpointsSidebarPane.js:274
> +    _populate: function()
> +    {
> +
> +        var categories = {
> +            "Mouse": ["click", "dblclick", "mousedown", "mouseup", "mouseover", "mousemove", "mouseout", "mousewheel"],
> +            "Keyboard": ["keydown", "keypress", "keyup"],
> +            "HTML frame/object": ["load", "unload", "abort", "error", "resize", "scroll"],
> +            "HTML form": ["select", "change", "submit", "reset", "focus", "blur"],
> +            "User interface": ["DOMFocusIn", "DOMFocusOut", "DOMActivate"],
> +            "Mutation": ["DOMAttrModified", "DOMCharacterDataModified", "DOMNodeInserted", "DOMNodeInsertedIntoDocument", "DOMNodeRemoved",
> +                         "DOMNodeRemovedFromDocument", "DOMSubtreeModified"]
> +        };
> +
> +        for (var category in categories) {
> +            var categoryTreeElement = new TreeElement(category);
> +            this.categoriesTreeOutline.appendChild(categoryTreeElement);
> +            categoryTreeElement.listItemElement.addStyleClass("event-category");
> +            categoryTreeElement.selectable = true;
> +

NIT: Extra newline up top.

I think these keys should be localized, since they are the title of TreeElement's displayed to the user.
Would be easy to solve with along the lines of: (and adding the strings.

  var categoryTreeElement = new TreeElement(WebInspector.UIString(category));


> WebCore/inspector/front-end/EventListenersSidebarPane.js:186
> +    this.propertiesElement.className = "event-properties properties-tree source-code"; /* Changed from "properties" */

How does this relate to your other changes? How does this affect the Event
Listeners sidebar pane in the Element's panel?


> WebCore/inspector/front-end/PropertiesSection.js:35
> +    this.propertiesElement.className = "properties properties-tree source-code";

Same comment. How does this affect the properties pane in the Elements panel?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.