[Webkit-unassigned] [Bug 46873] Rename @webkitspeech to @x-webkit-speech to follow HTML5 convention

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46873


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69334|review?                     |review-
               Flag|                            |




--- Comment #9 from Jeremy Orlow <jorlow at chromium.org>  2010-10-04 09:25:26 PST ---
(From update of attachment 69334)
View in context: https://bugs.webkit.org/attachment.cgi?id=69334&action=review

> WebCore/dom/make_names.pl:187
> +    if ($attr =~ m/^x-webkit/) {

Maybe do m/^x-webkit-(.*)/ and then use the $1 as the attribute?

> WebCore/dom/make_names.pl:193
> +        $attr =~ s/-/_/g;

You probably want this in both code paths, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.