[Webkit-unassigned] [Bug 29299] [Soup] Should not ignore body for redirection responses

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29299


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67041|review?                     |review-
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2010-10-04 09:00:50 PST ---
(From update of attachment 67041)
View in context: https://bugs.webkit.org/attachment.cgi?id=67041&action=review

This looks very reasonable to me, but because of the funky ChangeLogs and Gustavo's comment, I'll r-.

> LayoutTests/ChangeLog:13
> +        Tests that 302 redirections without Location do not ignore the
> +        body for redirection purpouses (the body could have a meta
> +        http-equiv=refresh)
> +
> +        [Soup] Should not ignore body for redirection responses
> +        https://bugs.webkit.org/show_bug.cgi?id=29299
> +
> +        * http/tests/navigation/redirect302-metaredirect-expected.txt: Added.
> +        * http/tests/navigation/redirect302-metaredirect.html: Added.

I think the order of these is typically reversed with the bug link coming first.

> WebCore/ChangeLog:11
> +        Body is now provided to WebKitGtk+ in some redirections (like 302)
> +        because it could be used by servers to perform clunky redirections
> +        for example using http-equiv=REFRESH
> +
> +        [Soup] Should not ignore body for redirection responses
> +        https://bugs.webkit.org/show_bug.cgi?id=29299
> +

Same thing here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.