[Webkit-unassigned] [Bug 47076] [cairo] Move some cairo functions to the CairoUtilities

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47076


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69613|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2010-10-04 07:54:44 PST ---
(From update of attachment 69613)
View in context: https://bugs.webkit.org/attachment.cgi?id=69613&action=review

Looks great! Please fix the following small issues before landing though.

> WebCore/platform/graphics/cairo/CairoUtilities.cpp:73
> +// We apply the pending path built via addPath to the Cairo context
> +// lazily. This prevents interaction between the path and other routines
> +// such as fillRect.

This comment doesn't make quite as much sense now that this function is shared between different source files. It's probably safe just to remove it.

> WebCore/platform/graphics/cairo/CairoUtilities.cpp:122
> +void drawPatternCairo(cairo_t* cr, cairo_surface_t* image, const IntSize& imageSize, const FloatRect& tileRect,

I think it you should call this drawPatternToCairoContext to match the name of the other helper functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.