[Webkit-unassigned] [Bug 10701] [ES5] Implement strict mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=10701





--- Comment #15 from Sam Weinig <sam at webkit.org>  2010-10-03 12:49:12 PST ---
(From update of attachment 69578)
View in context: https://bugs.webkit.org/attachment.cgi?id=69578&action=review

> JavaScriptCore/bytecode/CodeBlock.h:557
> +        bool m_isStrictMode;

I think this would read better as an enum. That way we are not passing around random bools.

> JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1553
> +    if (m_codeBlock->isStrictMode())
> +        return;

Since this is a little subtle, a comment indicating why you are returning early here might be nice.

> JavaScriptCore/parser/ASTBuilder.h:583
> +    bool isResolve(ExpressionNode* expr) { return expr->isResolveNode(); }
>  private:

It is nice to have new line before the access control modifier.

> JavaScriptCore/runtime/StrictEvalActivation.h:42
> +}
> +

We like to put // namespace JSC at the end.


I also, think this patch could use a more detailed ChangeLog, explaining most of the changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.