[Webkit-unassigned] [Bug 47053] Rename (and move) RenderPath to svg/RenderSVGPath

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47053


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krit at webkit.org




--- Comment #7 from Dirk Schulze <krit at webkit.org>  2010-10-02 22:57:19 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > > WebCore/ChangeLog:8
> > > +        Also renamed RenderObject::isRenderPath() to isSVGPath()
> > 
> > isRenderSVGPath(), should really be similar to the name of the renderer.
> 
> isSVGPath() is consistent with all the other RenderObject::isSVG*() methods.
> 
> > > WebCore/ChangeLog:22
> > > +        * rendering/RenderPath.cpp: Removed.
> > > +        * rendering/RenderPath.h: Removed.
> > > +        * rendering/RenderSVGHiddenContainer.cpp:
> > 
> > Please use 'svn mv' to move the files instead of copying. That is better for traversing  the history.
> 
> D'oh, of course! I was using 'git mv' and didn't verify that prepare-ChangeLog (and friends) supported it.

Hm, you're right, leave isSVGPath().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.