[Webkit-unassigned] [Bug 46790] GStreamer PlatformVideoWindow needs an API to prepare the widget before applying the overlay

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46790


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69176|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2010-10-02 11:23:20 PST ---
(From update of attachment 69176)
View in context: https://bugs.webkit.org/attachment.cgi?id=69176&action=review

I'm not sure what an appropriate name for this method should be (perhaps prepareForOverlay?), but I think that prepare is not descriptive enough.

> WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:198
> +        m_videoWindow->prepare(message);

The name prepare(...) seems a little ambiguous. I would prefer something a bit more descriptive.

> WebCore/platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp:40
> +    notImplemented();

An empty implementation is different than notImplemented(). This should just be empty.

> WebCore/platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:69
> +    notImplemented();

Same here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.