[Webkit-unassigned] [Bug 47020] Fixing crash when audio media player is destructed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47020





--- Comment #9 from Victoria Kirst <vrk at google.com>  2010-10-01 16:12:40 PST ---
(In reply to comment #7)
> Is the change in WebMediaPlayerClientImpl.cpp addressing the same bug, or something different?  I don't understand how that is related to the crash.

Yes, it is addressing the same bug. The WebMediaPlayerClientImpl object is created for all media players, including audio. The crash was occurring because the VideoLayerChromium platform layer was being constructed in the WebMediaPlayerClientImpl::create() method, which meant the (unused) VLC layer was being created for audio players. When destructing the audio players, the VideoLayerChromiums associated with them were never rendered and therefore did not have a LayerRenderer associated with it, which caused the layerRenderer() assert to fail.

So actually, the crash could be fixed with the WebMediaPlayerClientImpl.cpp change alone, but it makes sense to also add the if (!layerRenderer()) ... check into VideoLayerChromium.cpp for extra security.

> nit: should be one line description, bug link, newline, long description
Fixed x 2!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.