[Webkit-unassigned] [Bug 47020] Fixing crash when audio media player is destructed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47020





--- Comment #4 from Victoria Kirst <vrk at google.com>  2010-10-01 15:16:16 PST ---
(In reply to comment #2)

> r- for mangled ChangeLog. 
Oops! Thanks for the catch.

> Any chance of a test?  When will the layerRenderer() test fail?
So, it's a little tricky: LayerChromiums do not get initially created with a LayerRenderer associated with it, but instead there is a setLayerRenderer call which creates the association. Thus VideoLayerChromium only gets a LayerRenderer associated with it when the LayerRenderer is drawing that video layer, since that is where the LayerRenderer calls setLayerRenderer() (https://cs.corp.google.com/p#chrome/trunk/src/third_party/WebKit/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp&q=setLayerRenderer&exact_package=chrome&l=473).

In other words, the layerRenderer() test fails if we have created a VideoLayerChromium that is never drawn by the LayerRenderer... That in itself is kind of hard to test, but I can try to write a test that makes sure Audio and Video tags are destructed correctly (which was the problem that was causing all the crashes).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.