[Webkit-unassigned] [Bug 44920] Add layout tests for FileSystem API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44920





--- Comment #13 from Kinuko Yasuda <kinuko at chromium.org>  2010-10-01 15:08:54 PST ---
(In reply to comment #12)
> (From update of attachment 69306 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69306&action=review
> 
> > LayoutTests/fast/filesystem/resources/fs-test-shell.js:1
> > +/*
> 
> You're defining a whole new scripting language here in order to write filesystem tests.
> 1) Is this absolutely necessary?  The language looks very much like JavaScript...could it go more in that direction?  Can it be a JS library instead of an interpreter, as with e.g. http://jsmock.sourceforge.net/examples/, http://pivotal.github.com/jasmine/?  Even if it's just a set of JavaScript functions that do the same thing as your script functions, at least other folks editing the tests don't have to learn a new syntax, and can mix in new JS code without having to extend your interpreter.

Thanks very much for your comments.
Let me think about it, but to me this was the most straightforward way to write and debug so many test cases in short time.  And I wanted have something that can be easily extended for Sync cases.

(Of course we can do the same set of tests in pure JS code.  I wrote some tests in that way.)

> 2) Can we just use an existing library?
> 3) If we decide to go with a new domain-specific language, it should really be of general utility, and not buried down under the filesystem tests.  Lots of tests could make use of it.
> 4) There's enough code here in your interpreter that it really needs its own unit tests.

I don't think we want to do 2) or 3) because of the reason 4).  (And it's DSL because it's specific to FileSystem.)  Btw the interpreter part is basically just regexp's and it's less than 100 lines.

> > LayoutTests/fast/filesystem/resources/fs-test-shell.js:19
> > +    entry3 = ROOT.getFile('foo/nonexistent') raises 8
> 
> Is it raise or raises?

Both work...

> > LayoutTests/fast/filesystem/resources/fs-test-shell.js:220
> > +        this.log('Reseting the filesystem...');
> 
> typo: Resetting [affects expectations].

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.