[Webkit-unassigned] [Bug 46958] Add additional WKString API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46958





--- Comment #6 from Sam Weinig <sam at webkit.org>  2010-10-01 14:47:47 PST ---
(In reply to comment #5)
> (From update of attachment 69511 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69511&action=review
> 
> Looks good. r=me
> 
> > WebKit2/Shared/WebString.h:62
> > +        WTF::Unicode::ConversionResult result = WTF::Unicode::convertUTF16ToUTF8(&d, d + m_string.length(), &p, p + bufferSize - 1, true);
> 
> What does the true mean? maybe add a comment like /* ... */ in front of it?
> 
> > WebKitTools/TestWebKitAPI/Tests/WebKit2/WKString.cpp:34
> > +    WKStringRef string = WKStringCreateWithUTF8CString("hello");
> 
> Shouldn't you try constructing it using a "string" containing UTF8 specific chars?

Yep. I should.  I am going to ask ap to help me construct some more test cases (he is quite good at that).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.