[Webkit-unassigned] [Bug 46937] [chromium] Minor naming cleanup in WebDragData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46937


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69485|review?                     |review+
               Flag|                            |




--- Comment #5 from Tony Chang <tony at chromium.org>  2010-10-01 11:01:11 PST ---
(From update of attachment 69485)
View in context: https://bugs.webkit.org/attachment.cgi?id=69485&action=review

> WebKit/chromium/ChangeLog:14
> +        The list of methods that have been renamed:
> +        * hasFileNames() -> containsFilenames()
> +        * fileNames() -> filenames()

I think Ryosuke was saying that you can put this in the section below.  The : after the method names is supposed to be space to write comments about how you modified the method.

> WebKit/chromium/ChangeLog:22
> +        (WebKit::WebDragData::hasFileNames):

For example, here you would write "(WebKit::WebDragData::hasFileNames): renamed to containsFilenames"

> WebKit/chromium/public/WebDragData.h:84
>      WEBKIT_API void setFileNames(const WebVector<WebString>&);
>      WEBKIT_API void appendToFileNames(const WebString&);

Nit: Can you add a comment that these methods are deprecated/obsolete?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.