[Webkit-unassigned] [Bug 46960] Specify ALWAYS_INLINE at function declaration not function definition

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46960


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69426|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #5 from Geoffrey Garen <ggaren at apple.com>  2010-10-01 10:18:44 PST ---
(From update of attachment 69426)
Consider these docs:

http://gcc.gnu.org/onlinedocs/gcc/Inline.html
http://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Attribute-Syntax.html#Attribute-Syntax
http://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Function-Attributes.html

I'm pretty sure that ALWAYS_INLINE is only needed at the declaration site, not the definition site.

Even so, this patch is good, so r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.