[Webkit-unassigned] [Bug 46825] build fails if NETSCAPE_PLUGIN_API is disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46825





--- Comment #5 from sccameron at rim.com  2010-10-01 09:26:26 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Actually, I don't see how this would cause the build to fail. PluginView is still built even though NETSCAPE_PLUGIN_API is disabled.
> > 
> > 
> > The linker error is:
> > (Page.obj) : error LNK2001: unresolved external symbol "public: void __thiscall WebCore::PluginView::privateBrowsingStateChanged(bool)" (?privateBrowsingStateChanged at PluginView@WebCore@@QAEX_N at Z)
> > 
> > I'll post a new patch if you agree that it's a valid problem.
> > 
> 
> Are you including the plugins/PluginViewNone.cpp file in your build? Not doing that would cause those two build errors.

Yes it is.  WebCore.pro contains:

    contains(DEFINES, ENABLE_NETSCAPE_PLUGIN_API=1) {
    ...
    } else {
        SOURCES += \
            plugins/PluginPackageNone.cpp \
            plugins/PluginViewNone.cpp
    }

...and PluginViewNone.cpp is build in the logfile.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.