[Webkit-unassigned] [Bug 46892] webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode fails on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46892





--- Comment #7 from Adam Roben (aroben) <aroben at apple.com>  2010-10-01 06:57:45 PST ---
(In reply to comment #6)
> (In reply to comment #4)
> > Looks like we'll need to encode the args for windows.
> > 
> > See:
> > 
> >         args = map(unicode, args)  # Popen will throw an exception if args are non-strings (like int())
> > in POpen.run_command
> > 
> > I don't know what encoding cygwin would want things passed to it on the command line, but utf8 sounds like a good try.
> 
> It looks like Cygwin ends up calling mbstowcs, which uses the current code page. I wonder how we can get access to that from Python...

Even if we were to do this, we'd run into the problem of code pages not being able to encode certain characters. For instance, the code page on my machine is 437, which corresponds to the cp437 codec in Python. It is not able to handle the strings in the failing test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.