[Webkit-unassigned] [Bug 46825] build fails if NETSCAPE_PLUGIN_API is disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46825





--- Comment #3 from sccameron at rim.com  2010-10-01 06:52:11 PST ---
(In reply to comment #2)
> Actually, I don't see how this would cause the build to fail. PluginView is still built even though NETSCAPE_PLUGIN_API is disabled.


The linker error is:
(Page.obj) : error LNK2001: unresolved external symbol "public: void __thiscall WebCore::PluginView::privateBrowsingStateChanged(bool)" (?privateBrowsingStateChanged at PluginView@WebCore@@QAEX_N at Z)

I'll post a new patch if you agree that it's a valid problem.

In addition, the following linker error occurs:
(ScriptDebugServer.obj) : error LNK2001: unresolved external symbol "public: void __thiscall WebCore::PluginView::setJavaScriptPaused(bool)"
(?setJavaScriptPaused at PluginView@WebCore@@QAEX_N at Z)


...which requires the following change:

--- a/WebCore/bindings/js/ScriptDebugServer.cpp
+++ b/WebCore/bindings/js/ScriptDebugServer.cpp
@@ -433,9 +433,7 @@ void ScriptDebugServer::setJavaScriptPaused(FrameView* view, bool paused)
         Widget* widget = (*it).get();
         if (!widget->isPluginView())
             continue;
+#if ENABLE(NETSCAPE_PLUGIN_API)
         static_cast<PluginView*>(widget)->setJavaScriptPaused(paused);
+#endif
     }
 }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.